[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: local keymap patch for key-binding
From: |
David Kastrup |
Subject: |
Re: local keymap patch for key-binding |
Date: |
Wed, 13 Sep 2006 13:38:48 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
address@hidden (Kim F. Storm) writes:
> Your patch still looks good to me.
Well, I could not witness any adverse effect after some testing, it
tracks the behavior of read-key-sequence closely.
There is one concern that I have: the type of the "location" argument.
This currently is a key sequence. But it might make more sense to
turn this into the "location" data structure that `event-start' and/or
`event-end' return. This would make it much easier to feed lookup-key
with data produced from, say, `posn-at-x-y'.
In order to get this data easier, it might make sense to define a
convenience function.
(defun key-event (key)
"Return event from moused-base key sequence KEY."
(and (vectorp key)
(if (consp (aref key 0))
(aref key 0)
(and
(symbolp (aref key 0))
(> (length key) 1)
(consp (aref key 1))
(aref key 1)))))
Maybe even in C, as this function can be executed without consing.
I found that the current usage in the help echo fixup stuff does not
even have a key sequence to start from, just a mouse position.
So it would likely make more sense to rework the location argument
type to just be a mouse position.
That seems like the most basic unit for this argument that still makes
sense.
WDYT?
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
- Re: local keymap patch for key-binding, (continued)
- Re: local keymap patch for key-binding, Richard Stallman, 2006/09/12
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/12
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/12
- Re: local keymap patch for key-binding, Kim F. Storm, 2006/09/13
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/13
- Re: local keymap patch for key-binding, Kim F. Storm, 2006/09/13
- Re: local keymap patch for key-binding,
David Kastrup <=
- Re: local keymap patch for key-binding, Kim F. Storm, 2006/09/13
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/13
- Re: local keymap patch for key-binding, Kim F. Storm, 2006/09/13
- Re: local keymap patch for key-binding, Richard Stallman, 2006/09/13
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/13
- Re: local keymap patch for key-binding, Richard Stallman, 2006/09/13
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/13
- Re: local keymap patch for key-binding, Richard Stallman, 2006/09/13
- Re: local keymap patch for key-binding, Richard Stallman, 2006/09/13
- Re: local keymap patch for key-binding, David Kastrup, 2006/09/13