|
From: | Lennart Borgman |
Subject: | Re: shell-command - missing shell-quote-argument for program? |
Date: | Sun, 15 Oct 2006 11:35:16 +0200 |
User-agent: | Thunderbird 1.5.0.7 (Windows/20060909) |
Lennart Borgman wrote:
Kim F. Storm wrote:Lennart Borgman <address@hidden> writes:Index: flymake.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/progmodes/flymake.el,v retrieving revision 1.41 diff -c -r1.41 flymake.el *** flymake.el 16 Feb 2006 11:40:51 -0000 1.41 --- flymake.el 11 Oct 2006 22:57:10 -0000 *************** *** 1021,1027 **** (progn (flymake-get-project-include-dirs-from-cache basedir)) ;;else! (let* ((command-line (concat "make -C\"" basedir "\" DUMPVARS=INCLUDE_DIRS dumpvars"))(output (shell-command-to-string command-line)) (lines (flymake-split-string output "\n")) (count (length lines)) --- 1021,1029 ---- (progn (flymake-get-project-include-dirs-from-cache basedir)) ;;else ! (let* ((command-line (concat "make -C\"" ! (shell-quote-argument basedir)! "\" DUMPVARS=INCLUDE_DIRS dumpvars"))(output (shell-command-to-string command-line)) (lines (flymake-split-string output "\n")) (count (length lines))Shouldn't you remove the old quotes here? (let* ((command-line (concat "make -C " (shell-quote-argument basedir) " DUMPVARS=INCLUDE_DIRS dumpvars"))Yes, of course. Thanks.
It would have been better if I had attached the new patch too ;-) Here it is.(And excuse the name of the file name of the last patch I sent. It should of course have been something like ada-xref-el.patch)
Index: lisp/progmodes/flymake.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/progmodes/flymake.el,v retrieving revision 1.41 diff -c -r1.41 flymake.el *** lisp/progmodes/flymake.el 16 Feb 2006 11:40:51 -0000 1.41 --- lisp/progmodes/flymake.el 15 Oct 2006 09:17:25 -0000 *************** *** 1021,1027 **** (progn (flymake-get-project-include-dirs-from-cache basedir)) ;;else ! (let* ((command-line (concat "make -C\"" basedir "\" DUMPVARS=INCLUDE_DIRS dumpvars")) (output (shell-command-to-string command-line)) (lines (flymake-split-string output "\n")) (count (length lines)) --- 1021,1029 ---- (progn (flymake-get-project-include-dirs-from-cache basedir)) ;;else ! (let* ((command-line (concat "make -C " ! (shell-quote-argument basedir) ! " DUMPVARS=INCLUDE_DIRS dumpvars")) (output (shell-command-to-string command-line)) (lines (flymake-split-string output "\n")) (count (length lines))
[Prev in Thread] | Current Thread | [Next in Thread] |