Re: display-completion-list should not strip text properties

[Chong Yidong]

Glenn Morris <address@hidden> writes:

> The plan would be to remove all his contributions.
>
> Where some essential functionality goes, I imagine the person doing
> the removing would have to describe what the removed code did in
> general terms, then someone else would have to re-implement it
> independently. Annoying, but not insurmountable.

I went back and checked his contributions more carefully.  I now think
it's not difficult to revert almost all his changes.  There was a big
change he made to compile.el, but it was subsequently obseleted by
Daniel Pfeiffer's big revamp of compile.el on 2004-03-11, which
deleted the variables and functions that Kevin Rodgers had introduced
on 1996-11-04.

If we revert all his doc/comment fixes, and reimplement two of his
changes, we can bring the his remaining contributions to 9 small
changes spread over a total of 27 lines.  This will introduce a few
minor typos into Emacs, but absolutely no loss of functionality.

The two changes that we have to reimplement are the following:

1997-03-24  Kevin Rodgers  <address@hidden>

        * compile.el (grep-program): New variable.
        (grep-command): Use it, and test whether it supports the -e
        option; fix doc string (last command is stored in history variable).
        (grep-null-device): Declare before grep-program and grep-command.
        (grep-find-use-xargs, grep-find-command, grep-find-history):
        New variables.
        (grep-find): New command.
        (grep): Only concatenate grep-null-device to COMMAND when it's
        not nil (to support grep-find).

1996-09-12  Kevin Rodgers  <address@hidden>

        * loadhist.el (read-feature): New function.
        (unload-feature): Read FEATURE interactively with read-feature.

I can probably do this in a day.  Should I go ahead with the big revert?


--------------------------------


These are Kevin Rodger's changes in src/ChangeLog* and
lisp/ChangeLog*:

1994-06-17 mailabbrev.el (build-mail-abbrevs): 1 line fix.

1994-07-11 mailabbrev.el (define-mail-abbrev): 2 line fix.

1994-08-26 xfns.c (Fx_color_defined_p):
Obsolete. (Fx_color_defined_p has been rewritten in Lisp.)

1995-03-23 print.c (temp_output_buffer_setup): 1 line change.
Revertable.

1995-04-20 dired-x.el: 1 line fix.
2 line doc fix, revertable.

1995-05-19 mailalias.el (expand-mail-aliases): 2 line regexp fix.
Revertable.

1995-05-19 sendmail.el (mail-mode, mail-text): 6 line doc fix.
Revertable.

1995-06-30 mailabbrev.el (mail-resolve-all-aliases-1): 1 line fix.

1995-11-10 files.el (find-file-noselect): 3 line fix.

1995-12-13 ange-ftp.el (ange-ftp-load): 1 line fix.
           Plus 2 line fix in code that's been rewritten.

1996-09-12 loadhist.el (read-feature): New fun used only in unload-feature.
Trivially re-implementable.

1996-10-20 (compilation-skip-to-next-location): New var, defaults to nil
           5 line fix to use it.
Revertable.

1996-11-04 compile.el
(compile-highlight-display-limit): New var, since deleted
(compilation-handle-exit): This function has been rewritten.
(compile-reinitialize-errors): This function has been deleted.
(compilation-forget-errors): This function has been rewritten.

1997-03-24 compile.el (grep-program): New variable.
        (grep-command): New command.
        (grep-find): New command.

1997-11-02 emacs-lisp/byte-opt.el (byte-optimize-concat): New function.
Revertable.  (It's an optional optimization.)

1997-12-22 simple.el (previous-matching-history-element): 5 line fix.

1998-06-03 replace.el (esc-map): 1 line keybinding.

1998-07-07 vc.el (vc-finish-logentry): 1 line fix.

2003-03-06 ffap.el (dired-at-point): 2 line change.
Revertable.

2003-03-07 dired-x.el (dired-guess-shell-case-fold-search): New user option.
           (dired-guess-default): 1 line change to use it.
Revertable.

2003-07-25  menu-bar.el (menu-bar-tools-menu): 2 line menu string change.
Revertable.

2003-09-01 progmodes/compile.el (previous-error): 5 line change.

2004-11-12 desktop.el (desktop-create-buffer, desktop-save): Four line
           optimization.
Revertable.

2005-08-20 progmodes/compile.el (compilation-disable-input) New
           defcustom, defaults to nil.
           (compilation-start): 2 line change to use it.
Revertable.

2005-12-10 emacs-lisp/lisp.el (lisp-complete-symbol): 6 line fix.

2006-01-27 textmodes/flyspell.el (flyspell-incorrect, flyspell-duplicate):
           Two line doc fix.
Revertable.

2006-12-22 progmodes/sh-script.el (sh-make-vars-local): 1 line typo in string.
Revertable.

2006-12-30 files.el (backup-buffer): 1 line change.
Revertable.

2007-03-04 diff-mode.el (diff-mode): 4 line doc fix.
Revertable.