Re: Problems setting byte-compile-warnings to t

[Richard Stallman]

    Looking at it some more, the value of byte-compile-warnings set by
    byte-compile-close-variables gets clobbered when
    byte-compile-insert-header is called. It changes the buffer to
    " *Compiler Input", where the buffer local value shadows the value in
    the let-binding.

It is true that it changes the current buffer, and that is ugly.
Perhaps we should make it use with-current-buffer.

But as soon as it returns, you get to

      (with-current-buffer inbuffer
        ...)

followed by

      (and filename (byte-compile-fix-header filename inbuffer outbuffer))))

and that function does with-current-buffer too.

So where is the code that is affected by the change in the current
buffer made by byte-compile-insert-header?  Is it in the caller of
byte-compile-from-buffer?  I don't see how that could happen, since
the byte-compile-close-variables form has already exited there.

Is it inside byte-compile-insert-header itself?
I don't see where in that function it could be.