|
From: | Jan Djärv |
Subject: | Re: desupporting X10 and old X11 releases |
Date: | Tue, 30 Oct 2007 08:33:31 +0100 |
User-agent: | Thunderbird 2.0.0.6 (X11/20070728) |
Eli Zaretskii skrev:
Date: Mon, 29 Oct 2007 08:30:09 +0100 From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= <address@hidden> Cc: address@hidden, address@hidden, address@hiddenI don't know if oldXMenu is used (it is kind of strange looking :-), but it compiles and works. But I suspect that those that can't use any X toolkit use Lucid. I'd say we can get rid of it.Sorry for my failing memory, but isn't oldXMenu used fornon-USE_X_TOOLKIT compilation of xmenu.c?
Yes.
If so, I wouldn't recommend deleting it, because that's currently the only way to build and test that branch of xmenu.c (the other build which used to use it was the MSDOS port, but it's broken on the trunk for the time being). We might need it again if and when someone writes the code to support menus on a Unix text terminal.
IMHO, possible future development is not a good reason to keep almost unused code. After all, the code is in CVS if it is needed in the future. Also, adding menu code is as easy in the toolkit code as in the non-toolkit code. The main difference is that the non-toolkit code does not use callbacks. Otherwise there is much duplication.
Jan D.
[Prev in Thread] | Current Thread | [Next in Thread] |