Re: Emacs pretest 22.1.91

[Juanma Barranquero]

On Wed, Feb 27, 2008 at 3:11 PM, Juanma Barranquero <address@hidden> wrote:

>  OK, what about this simpler change then?

>  2008-02-27  Juanma Barranquero  <address@hidden>
>
>         * faces.el (x-create-frame-with-faces): Delay call to
>         `tool-bar-setup' if invoked before loading the init files.

<sigh> What a nice can of worms.

After the patch above, with this simple .emacs:

;;;;;;;;;; emacs.el ;;;;;;;;;;
(with-temp-buffer (compilation-mode 1))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

you get an error:

  signal(wrong-type-argument (keymapp nil))
  define-key-after(nil [previous-error-no-select] (menu-item
"previous-error-no-select" previous-error-no-select :image (image
:type xpm :file "c:/emacs/trunk/etc/images/left-arrow.xpm") :rtl
"right-arrow" :help "Goto previous error"))
  tool-bar-local-item("left-arrow" previous-error-no-select
previous-error-no-select nil :rtl "right-arrow" :help "Goto previous
error")
  byte-code(...)
  (compilation-mode 1)
 [... etc ]

That's because compile.el (on the trunk) has

(defvar compilation-mode-tool-bar-map
  (if (display-graphic-p)
      (let ((map (butlast (copy-keymap tool-bar-map)))
        ...

But before calling `tool-bar-setup', `tool-bar-map' contains just '(keymap)).

This is not a new bug; if you add the tool-bar stuff from the trunk's
compile.el to the EMACS22_BASE compile.el. it fails too. It just
hadn't been noticed before.

The only way out I can see right now is promoting `tool-bar-setup' to
be a user (or at least, package-developer) visible function. For
example, to change the above code to

(defvar compilation-mode-tool-bar-map
  (when (display-graphic-p)
      (tool-bar-setup)
      (let ((map (butlast (copy-keymap tool-bar-map)))
        ...

I'm feeling deeply unclean right now.

             Juanma