emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Faces applies to new frames


From: Stefan Monnier
Subject: Re: Faces applies to new frames
Date: Sun, 29 Jun 2008 16:00:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> Yes, it makes a bit more sense, except that now I wonder why this
>> code would be needed at all?  Isn't the `font' frame-parameter
>> automatically always kept up-to-date with the font of the
>> `default' face?  If not, I think it should, and hence it should be done
>> elsewhere so that it's also true when we later change the default face
>> via `set-face-attributes' or something like that.

> This is because internal-merge-in-global-face (which is called in the
> middle of face-set-after-frame-default) merges in the face vector from
> face-new-frame-defaults without updating the `font' frame parameter.

> Every other place that changes the font uses set-face-attribute, which
> updates the `font' parameter correctly.

> I suppose we could change internal-merge-in-global-face to update the
> frame parameters itself, instead of adding a separate line in faces.el
> to do it.

Yes, that would make a lot more sense, wouldn't it?
[ Tho, I'd have expected that updating the `font' frame-parameter was
  done at a lower-level, in a single place. ]


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]