|
| From: | Stefan Monnier |
| Subject: | Re: Emacs-diffs Digest, Vol 94, Issue 89 |
| Date: | Sat, 25 Sep 2010 00:25:10 +0200 |
| User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
>> - int frame_lines = FRAME_LINES (frame);
>> + EMACS_INT frame_lines = FRAME_LINES (frame);
> Is this really a good idea? There's no chance the number of lines in
> a frame will overflow a 32-bit int any time soon. SO I think an
> explicit cast to int is a better solution here.
BTW, if you add casts, as much as possible add them only inside macros,
Stefan
| [Prev in Thread] | Current Thread | [Next in Thread] |