Re: filenotify.el

[Davis Herring]

> (defun magit-filenotify-start ()
>   "Start watching for changes to the source tree using filenotify.
> This can only be called from a magit status buffer."
>   (unless file-notify-support
>     (error "Support for `file-notify' required."))
>   ...
> 
> There could be support even if `file-notify-support' is nil. This
> variable reflects only, whether a respective library has been linked to
> Emacs, working for local files. `file-notify' could run for remote
> files, even if it is not supported locally.
> 
> Maybe we shall spend a new function
> 
> (defun file-notify-supported-p (file)
>   "Returns non-nil if filesystem pertaining to FILE could be watched."
>   ...
> 
> Comments?

Why not just let the error from the underlying notification request
appear?  (This is the usual bit about "don't call stat(2) before
open(2); just deal with failures from the latter".)

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.