emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Eldoc mode in eval-minibuffer


From: Eli Zaretskii
Subject: Re: Eldoc mode in eval-minibuffer
Date: Mon, 20 Jan 2014 21:25:10 +0200

> From: Stefan Monnier <address@hidden>
> Cc: Leo Liu <address@hidden>, address@hidden
> Date: Mon, 20 Jan 2014 12:59:26 -0500
> 
> > Besides the usual gripes about such prominent changes in behavior
> > being made during feature freeze,
> 
> I don't know of such a change.  AFAIK the change to eldoc installed
> recently was about changing the implementation of
> eldoc-post-insert-mode, to make it more like the normal eldoc mode.
> I.e. a change in implementation more than in behavior.
> 
> >  . Since it is not in NEWS, chances are it will never get mentioned in
> >    the manual, which is bad for default behavior.
> 
> IIUC this change in behavior was not intended.
> 
> Leo, can you take a look to see what's going on?

This part of r115987 does it:

=== modified file 'lisp/simple.el'
--- lisp/simple.el      2014-01-09 01:59:19 +0000
+++ lisp/simple.el      2014-01-12 04:00:03 +0000
@@ -1387,6 +1387,7 @@ display the result of expression evaluat
         (lambda ()
           (add-hook 'completion-at-point-functions
                     #'lisp-completion-at-point nil t)
+         (eldoc-mode 1)
           (run-hooks 'eval-expression-minibuffer-setup-hook))
       (read-from-minibuffer prompt initial-contents
                             read-expression-map t




reply via email to

[Prev in Thread] Current Thread [Next in Thread]