[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] 04/07: diff-hl-mode: defer diff-hl-update until diff-hl-mode-
|
From: |
Dmitry |
|
Subject: |
Re: [elpa] 04/07: diff-hl-mode: defer diff-hl-update until diff-hl-mode-on-hook |
|
Date: |
Mon, 11 Aug 2014 04:01:17 +0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> + (add-hook (if vc-mode
>> + 'diff-hl-mode-on-hook
>> + 'find-file-hook)
>> + 'diff-hl-update t t)
>
> I think this deserves a comment (both for the use of a hook, and for the
> use of a different hook depending on vc-mode).
>
>> (add-hook 'after-revert-hook 'diff-hl-update nil t)
>> (add-hook 'magit-revert-buffer-hook 'diff-hl-update nil t)
>
> And I think this deserves a comment as well explaining why
> after-revert-hook doesn't already cover the magit case.
Some explanations added.