emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: include Ada Reference Manual info files in ada-mode ELPA package?


From: Stephen Leake
Subject: Re: include Ada Reference Manual info files in ada-mode ELPA package?
Date: Sat, 27 Sep 2014 23:12:03 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (windows-nt)

Stephen Leake <address@hidden> writes:

> Perhaps making the ARM a separate ELPA package would be the right
> choice. It would be an info-only package, so there would be no .el file
> to hold the meta-data header. I guess I'd have to add one just for that.
> Would that be ok?

I tried this. It fails because `archive--metadata' in
elpa/admin/archive-contents.el thinks it's a simple (one-file) package,
because there is only one .el file. A simple fix is to also include
'dir' in that check. Here's a patch against ELPA head (also fixes a
small typo in an error message):

--- a/admin/archive-contents.el
+++ b/admin/archive-contents.el
@@ -167,7 +167,7 @@ EXTRAS is an alist with additional metadata.
 
 PKG is the name of the package and DIR is the directory where it is."
   (let* ((mainfile (expand-file-name (concat pkg ".el") dir))
-         (files (directory-files dir nil "\\.el\\'")))
+         (files (directory-files dir nil "^dir$\\|\\.el\\'")))
     (setq files (delete (concat pkg "-pkg.el") files))
     (setq files (delete (concat pkg "-autoloads.el") files))
     (cond
@@ -201,7 +201,7 @@ PKG is the name of the package and DIR is the directory 
where it is."
                   (list (cons :url url)
                         (cons :keywords keywords)))))))
      (t
-      (error "Can find main file %s file in %s" mainfile dir)))))
+      (error "Can't find main file %s file in %s" mainfile dir)))))
 
 (defun archive--process-simple-package (dir pkg vers desc req extras)
   "Deploy the contents of DIR into the archive as a simple package.


With that fix, the ada-ref-man package installs, and the info files show
up nicely.

Ok to install the patch in ELPA?

--
-- Stephe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]