Re: Can we not introduce frivolous indentation change to define-minor-mode?

[Oleh Krehel]

Hi Leo,

Leo Liu <address@hidden> writes:

> The introduction of (indent 1) to define-minor-mode. I have quite a few
> define-minor-mode instances starting like this:
>
> (define-minor-mode some_fancy_mode nil
>   ...)
>
> The indentation is changed between emacs < 25 and 25.

I added an (indent 1) statement around a year ago. The reason is that it
didn't have one before, and that (indent 1) is obviously the correct
indentation level.

Every `define-minor-mode' statement in the core (and org-mode, and most
of ELPA) already obeys the (intent 1) convention. It seems that you were
defining minor modes in your config (and ELPA) with nil instead of the
docstring. I suggest to either add a docstring or put a newline after
the minor mode name.

Oleh