emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Add systemd socket launching support


From: Eli Zaretskii
Subject: Re: [PATCH v3] Add systemd socket launching support
Date: Thu, 31 Mar 2016 20:41:23 +0300

> From: Stefan Monnier <address@hidden>
> Date: Thu, 31 Mar 2016 13:11:25 -0400
> Cc: address@hidden
> 
> > Internally, sd_listen_fds() checks whether the $LISTEN_PID environment
> > variable equals the daemon PID. If not, it returns
> > immediately. Otherwise, it parses the number passed in the $LISTEN_FDS
> > environment variable, then sets the FD_CLOEXEC flag for the parsed
> > number of file descriptors starting from SD_LISTEN_FDS_START. Finally,
> > it returns the parsed number.
> 
> Then I think it would be better to follow an approach like the one with
> which you started (i.e. without the internal systemd_socket variable),

The original patch included the internal variable.

And I object to exposing file descriptors to Lisp, certainly when that
is not necessary.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]