Re: [PATCH v3] Add systemd socket launching support

[Matthew Leach]

Matthew Leach <address@hidden> writes:

> Hi Stefan,
>
> Stefan Monnier <address@hidden> writes:
>
>>> And I object to exposing file descriptors to Lisp, certainly when that
>>> is not necessary.
>>
>> In other similar functionality I've seen over the years, an alternative
>> was to pass the fd as an additional argument on the command line, but in
>> any case whether it's received from the environment or the command line,
>> the file-descriptor to use will just be an integer, and it's already
>> exposed to Lisp.
>>
>> So, AFAICT we just need 3 elements:
>> - a function to get the FD number from systemd (which we could write in
>>   Elisp, but is much better implemented as a call to systemd's support
>>   library).
>> - a way to create a process-object from an existing file-descriptor
>> number.
>
> Should the socket descriptor number be passed in from Lisp, or should
> this be a Boolean flag that tells make-network-process to consult an
> internal variable?  We can separate the libsystemd code from the
> make-network-process logic easily in both scenarios.

I forgot to mention, my vote is for latter as it prevents users passing
in garbage to make-network-process.
-- 
Matt