emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation warnings in mouse.el


From: Dmitry Gutov
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 17:41:30 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0

On 07/13/2016 05:30 PM, Eli Zaretskii wrote:

But if each defcustom has its :group, then the need for consistency is
no longer a requirement, is it?

The need for consistency is always there when one is writing code.

Speaking of personal preference, however, I'd rather using the `mouse'
group didn't work, in the absence of a defgroup somewhere.

If we can do something to that effect, I don't think I will object.

We could start with a warning in Emacs 26, and make it so in 28-ish, maybe.

How would removing a defcustom, or merely adding one, lead to a bug?

Well, not bug, a compilation warning that suddenly appears out of
nowhere for code that was there for a long time.

For new code, AFAIU. Not for code that has been there for a while.

AFAIU, extant defcustoms could start causing warnings, given some
changes in other defcustom's.  Am I mistaken?

I believe so.

In short, I think having one defcustom depend on another is bad for
maintenance.

It would be bad, if it were so. defcustom depend on defgroup.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]