emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Checking in files with trailing white space


From: Alan Mackenzie
Subject: Re: Checking in files with trailing white space
Date: Tue, 13 Dec 2016 18:28:22 +0000
User-agent: Mutt/1.5.24 (2015-08-30)

Hello, Paul.

On Mon, Dec 12, 2016 at 02:57:42PM -0800, Paul Eggert wrote:
> On 12/12/2016 02:16 PM, Alan Mackenzie wrote:
> > However, this absolute prohibition on trailing spaces is fascistic.
> > Some files (for example, test files) have essential trailing spaces in
> > them

> I added a comment to the pre-commit file to help out others in your 
> situation; see the attached patch.

Thanks.  That looks just the job!

> As it is all too easy to overlook trailing white space when reading 
> source code, I'd rather avoid having significant whitespace in committed 
> files. If I were writing those test cases, I'd commit files that didn't 
> have trailing whitespace, and convert them to 
> files-with-trailing-whitespace while running the test.

Alternatively, could the pre-commit git hook be adapted to warn the
committer about trailing space and ask him for confirmation?  I couldn't
see an easy way over the weekend, but it might be possible, somehow.

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]