[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Killing frame-locals
From: |
Stefan Monnier |
Subject: |
Re: Killing frame-locals |
Date: |
Wed, 21 Dec 2016 14:27:22 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) |
OK, looks like there's no objection, so I'll install the patch.
Thanks,
Stefan
>>>>> "Noam" == Noam Postavsky <address@hidden> writes:
> On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier
> <address@hidden> wrote:
>> Ping?
>>
>> I'll take care of the patch, if we agree,
>>
>>
>> Stefan
>>
>>
>>>>>>> "Stefan" == Stefan Monnier <address@hidden> writes:
>>
>>>> + else if (sym->redirect == SYMBOL_LOCALIZED
>>>> + && SYMBOL_BLV (sym)->frame_local)
>>>> + xsignal1 (Qtrapping_frame_local, symbol);
>>
>>> BTW, make-variable-frame-local has been declared obsolete since
>>> Emacs-22.2, so I think now is a good time to get rid of
>>> frame-local variables.
>>
> I did a web search for make-variable-frame-local, I found only
> perspective-el still using it. I think it's a fairly popular package;
> on the other hand, it's not in GNU ELPA, and it's not like they didn't
> have warning in advance...
> https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197
> ;; make-variable-frame-local is obsolete according to the docs,
> ;; but I don't want to have to manually munge frame-parameters
> ;; all the time so I'm using it anyway.
> (make-variable-frame-local