Re: Reformat all of src/

[Yuri Khan]

On Wed, Dec 28, 2016 at 11:59 PM, John Wiegley <address@hidden> wrote:

> If we were going to reformat all the sources, I'd rather we observe the rule
> "never use tabs". I don't see what benefit they possibly offer.

They offer customizable indentation, but only for some coding styles.
For the GNU style where function parameters and arguments on the
continuation lines are lined up with those on the first line, tabs are
indeed harmful.

GNU style:

    void some_function(int arg1,
    ...................int arg2)

Tab-friendly style:

    void some_function(int arg1,
    <-->int arg2)

Bad:

    void some_function(int arg1,
    <--><--><--><-->...int arg2)

Equally bad:

    void some_function(int arg1,
    <------><------>...int arg2)