[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Smie-auto-fill doesn’t respect comment-auto-fill-only-comments
From: |
Stefan Monnier |
Subject: |
Re: Smie-auto-fill doesn’t respect comment-auto-fill-only-comments |
Date: |
Sun, 21 May 2017 17:03:57 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
> +(defun internal-auto-fill ()
> + "The function called by `self-insert-command' to perform auto-filling."
> + (when (or (not comment-auto-fill-only-comments)
> + (nth 4 (syntax-ppss)))
> + (do-auto-fill)))
Please check also comment-start, since you don't want to check
(syntax-ppss) if there's no comment-start defined. Well, technically,
it shouldn't make any difference, but it's the way it's been defined so
far, so it makes sense to preserve it.
The patch looks good, but please also remove the
comment-auto-fill-only-comments handling from newcomment.el [ BTW, yes, not
only I feel silly about this name now, but I already felt silly about
it when I came up with it. ]
Stefan