Re: master fails to build on FreeBSD when ACL support is on

[Eli Zaretskii]

> Cc: address@hidden, address@hidden, address@hidden
> From: Paul Eggert <address@hidden>
> Date: Sat, 20 Jan 2018 19:41:32 -0800
> 
> Joseph Mingrone wrote:
> > the problem only seems to occur when /tmp supports ACLs,
> > but $WRKDIR (location where the tarball is extracted and the build
> > occurs) does not.
> 
> The problem occurs because (rename-file A B) signals an error if A has ACLs 
> and 
> B's file system does not support ACLs. This is because rename-file calls 
> (copy-file A B nil t t t) and that last "t" tells copy-file to copy ACLs.

Why doesn't copy-file (or qcopy_acl?) use acl_errno_valid, as we do in
set-file-acl?  Is there a reason for this inconsistency?