[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-26 c87d04e: Avoid aborts in 'md5'
From: |
Eli Zaretskii |
Subject: |
Re: emacs-26 c87d04e: Avoid aborts in 'md5' |
Date: |
Wed, 28 Feb 2018 17:52:07 +0200 |
> From: Michael Albinus <address@hidden>
> Cc: Eli Zaretskii <address@hidden>
> Date: Wed, 28 Feb 2018 09:30:59 +0100
>
> > + if (!STRINGP (object))
> > + signal_error ("Invalid object argument",
> > + NILP (object) ? build_string ("nil") : object);
> > return SSDATA (object);
> > }
>
> Don't we call CHECK_STRING (object) in such cases, which raises the
> standardized error Qwrong_type_argument?
Using CHECK_STRING would produce a misleading error message, because
the APIs that call extract_data_from_object accept objects other than
strings.
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', (continued)
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Andreas Schwab, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Michael Albinus, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Andreas Schwab, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Eli Zaretskii, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Andreas Schwab, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Eli Zaretskii, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Paul Eggert, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Eli Zaretskii, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Paul Eggert, 2018/02/28
- Re: emacs-26 c87d04e: Avoid aborts in 'md5', Eli Zaretskii, 2018/02/28
Re: emacs-26 c87d04e: Avoid aborts in 'md5',
Eli Zaretskii <=