RE: `facemenu-set-face' doesn't add face to the Face menu

[Drew Adams]

        To "add" FACE in the first paragraph means to apply it to
        the region.

    It means to add it to the list of faces for the region.
    I think that's what the command does.  Do you think I'm mistaken?

No, I wasn't thinking about merging. Perhaps it would help to have the
manual's description of `facemenu-set-face' cross-reference the section that
explains that text can have a list of faces, and how that works. It's not
needed for the doc string, of course.

        So, perhaps the doc string of
        `facemenu-listed-faces' also needs to be clarified (since
        the other two doc strings just refer to it wrt this).

    Maybe so, but it is clear to me, so I don't see what aspect needs
    improvement.  Can you explain?

As I said, "I don't understand how `facemenu-listed-faces' determines
whether a face gets added to the face menu by `facemenu-add-face'." I think
the doc string for the latter is now correct, but I'm not clear on how
`facemenu-listed-faces' works.

If `facemenu-listed-faces' is t, then I guess the face would be added to the
menu.

If `facemenu-listed-faces' is a list that doesn't include the face, then I
guess the face would not be added if and only if it is in that list. Is that
correct?

The part of the `facemenu-listed-faces' doc string that says "set this list
before loading facemenu.el, or add a face to it before creating that face if
you want it to be listed" is not clear to me in this context. If you add a
face to `facemenu-listed-faces' before you use `facemenu-set-face', doesn't
that count (isn't the face added to the menu)? But that's not "before
creating that face" and it's not "before loading facemenu.el", so the doc
string suggests that it wouldn't be added to the menu.

If `facemenu-listed-faces' is nil, what happens? I think that nothing is
said about this case in the doc string of `facemenu-listed-faces', even
though nil is the default value.