Re: emacsclient horribly broken

[Juanma Barranquero]

On 10/31/06, Tim Van Holder <address@hidden> wrote:

> Well it was broken, and because Windows was involved "horribly" came to mind :-D

I suspected as much ;)

> Follows.

OK. BTW, have you ever signed papers for changes in Emacs? The amount
of patches till now is fine, I think, but more extensive changes would
require signed papers.

> -# include <sys/ioctl.h>
> +/* FIONBIO can be in either sys/ioctl.h or sys/filio.h */
> +# if HAVE_SYS_IOCTL_H
> +#  include <sys/ioctl.h>
> +# endif
> +# if HAVE_SYS_FILIO_H
> +#  include <sys/ioctl.h>
> +# endif

Shouldn't that last one be "# include <sys/filio.h>"?

> -#if !defined (HAVE_SOCKETS)
> +#if !defined (HAVE_SOCKETS) || !defined(HAVE_INET_SOCKETS)

So, both are required?

BTW: please send future patches as attached files. I don't like what
Gmail does sometimes to patches included as text in the message.

Thanks a lot for your help,

                   /L/e/k/t/u