emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacsclient horribly broken


From: Juanma Barranquero
Subject: Re: emacsclient horribly broken
Date: Tue, 31 Oct 2006 13:22:57 +0100

On 10/31/06, Jan Djärv <address@hidden> wrote:

> It is compatible with Windows?

I don't know.  Why is it important?

Because I cannot test it in other platforms, so I've chosen the way
that seemed to work more generally.

We should do the right thing for each platform.

Agreed.

process.c only uses FIONBIO in one place and only on STRIDE, but O_NONBLOCK is
used many times.

I know.

sysdep.c also uses it in one place, this really should be O_NONBLOCK instead.

If you say so; I don't know.

w32.c is MS Windows specific, so it does not count.

For some definition of "does not count", sure.

Something like this would handle all cases:

#ifdef O_NONBLOCK
/* Use O_NONBLOCK. */
#else
#ifdef O_NDELAY
/* Use O_NDELAY */
#else
/* Use FIONBIO */
#endif
#endif

Please, fill the blanks and I'll be happy to install it.

--
                   /L/e/k/t/u

reply via email to

[Prev in Thread] Current Thread [Next in Thread]