Re: emacsclient horribly broken

[Jan Djärv]

Juanma Barranquero skrev:
> On 10/31/06, Jan Djärv <address@hidden> wrote:
>
> > We should use O_NONBLOCK.  It is more widespread on Unix nowdays, and 
> > FIONBIO
> > does not have exactly the same sematics.
>
> It is compatible with Windows?

I don't know.  Why is it important?  We should do the right thing for each 
platform.

> > How do we hande this elsewhere in Emacs?
>
> src/process.c, src/sysdep.c and src/w32.c already use FIONBIO.

process.c only uses FIONBIO in one place and only on STRIDE, but O_NONBLOCK is 
used many times.
sysdep.c also uses it in one place, this really should be O_NONBLOCK instead.
w32.c is MS Windows specific, so it does not count.

Something like this would handle all cases:

#ifdef O_NONBLOCK
/* Use O_NONBLOCK. */
#else
#ifdef O_NDELAY
/* Use O_NDELAY */
#else
/* Use FIONBIO */
#endif
#endif

        Jan D.