Fwd: [Fab-user] Patch for prompt and require

[Niklas Lindström]

Sorry, missed the "reply to all".


---------- Forwarded message ----------
From: Niklas Lindström <address@hidden>
Date: Tue, Oct 21, 2008 at 10:52 PM
Subject: Re: [Fab-user] Patch for prompt and require
To: Jeff Forcier <address@hidden>


Jeff, Christian, all,

of course; I'll do my best. I have just written it down, but before I
expose you to it, I have two questions:

1. Should I divide my list into several mails (e.g. three:
"straightforward changes", "the change for skipping invoked commands"
and "remaining suggestions")?

2. Regarding references to commits: are my commit messages at
<http://github.com/niklasl/fabric/commits/master> ok enough to see the
timeline of when things appeared?

I tried to be fairly atomic in my commits. I also hope that my changes
are isolated enough to be clearly visible when diffing against the
official latest fabric.py (in Christian's repo). Please note that I
have no "incomplete code" in my github repo now -- I consider it all
ready for review.

(And I have merged the latest master of Christian's github repo, so I
expect that the things you've (Jeff) done are present in my codebase.)

Best regards,
Niklas



On Tue, Oct 21, 2008 at 5:56 PM, Jeff Forcier <address@hidden> wrote:
> Hey everyone,
>
> I've been trying to gather up all the mails about Niklas' changes and
> proposed changes but it's all making my head spin. I also suspect that
> some of his issues may have become non-issues after the merge of my
> execution branch into main Fabric (since he wrote his initial email
> before that point in time).
>
> Niklas, could you possibly do me/us a *huge* favor and:
>
> 1. Go over your original list of proposed changes, and see how many of
> them are still applicable to the latest Fabric trunk;
> 2. For those which do still apply, make a note as to which ones you've
> coded changes for, and which ones remain un-worked-on; and for the
> former, note which commit(s) in your GitHub repo match up to them;
> 3. Also for each of those, gather up any feedback from myself and Christian.
>
> In other words -- you've got a ton of changes and I personally would
> love to see an organized list + status update. Then we can focus on
> one at a time.
>
> Or, in yet other words -- pretend we've got a decent code-related
> ticket tracker already (we don't :() and try to set things up so there
> are individual "tickets". I find it's far, far easier to get things
> done and make good decisions when stuff is compartmentalized like this
> -- as opposed to these large all-in-one emails :)
>
> Thanks,
> Jeff
>