Re: [pooma-dev] Patch: Test Files

[Jeffrey Oldham]

On Wed, Mar 21, 2001 at 09:06:47AM -0800, Julian C. Cummings wrote:
> Jeffrey,
> 
> I'm a bit concerned about your changes to 
> prepend std:: to uses of iostream.  Jim 
> raised the point that this may not yet be
> supported by all compilers in use.  Also,
> this sort of change needs to be done in a 
> universal way across the entire Pooma code
> base.  Finally, as Jim noted, it might be 
> better to go with specific using declarations 
> at the top of .cpp files, rather than writing
> std:: everywhere.  Did you ever address these
> points that Jim raised?  I tend to agree with
> him on these things.

That was a mistake.  I just reversed the changes to
Domain/NewDomain/Constructors/NewDomainConstructor.cpp and
Domain/Range/Constructors/RangeConstructor.cpp.  I am just going to
let the other changes drop.  They are not important right now,
especially considering the uncertainty whether any of the test code is
important.

Note the attached patch was _reversed_.

Sorry,
Jeffrey D. Oldham
address@hidden

> -----Original Message-----
> From: Jeffrey Oldham [mailto:address@hidden
> Sent: Tuesday, March 20, 2001 9:47 PM
> To: address@hidden
> Subject: [pooma-dev] Patch: Test Files
> 
> 
> Previously proposed changes to Array/Test/ArrayTest.cpp,
> Shared/dclock.cpp, and
> Utilities/RefCounting/RefCountedBlockPtr/RefCountedBlockPtrTest.cpp
> were omitted.  (Did we reach any consensus on portable dclock.cpp
> code?)
> 
> Domain/Loc/Characteristics/LocCharacteristics.cpp:
> 
>       * Creating a Loc<1> from a scalar does not seem to be supported.
> 
> Domain/NewDomain/Constructors/NewDomainConstructor.cpp:
> 
>       * Prepend iostream functions with "std::".
> 
> Domain/Range/Constructors/RangeConstructor.cpp:
> 
>       * Prepend iostream functions with "std::".
> 
> Domain/Range/Constructors/makefile:
> 
>       * Fix typo in main target from creating this makefile by copying.
> 
> Engine/BrickEngine/BrickEngine/BrickEngineTest.cpp:
> 
>       * s/BaseDomain_t/Base_t/
> 
> Review by:    Jim Crotinger
> Tested on     sequential Linux with gcc mainline

revtest.patch
Description: Text document