Re: [ft-devel] FreeType 2.3.0 release candidate 1 is available

[Detlef Würkner]

Hello!

Sorry for the late response, could not find the time earlier.

address@hidden (David Turner) wrote:

[...]
>   III. IMPORTANT CHANGES
[...]
>   III. MISCELLANEOUS

IV, not III ?

> Building/Installation volunteers are welcomed. I'm especially
> curious about warning messages happening during compilations on
> exotic platforms, since we try to *completely* prevent them in
> our official releases.

With a CVS checkout from yesterday evening I had to apply the following
patches to be able to compile and link it with gcc 4.0.3 for AmigaOS4 with
-Wshadow -Werror. Sorry, cant commit the changes myself, some problems
with my ssh key.

Changes which rename "index" (its a C function in <string.h> here
which causes -Wshadow warnings):

--- src/truetype/ttdriver.c.ori 2006-11-19 09:19:16.000000000 
+++ src/truetype/ttdriver.c     2007-01-14 17:11:47.000000000 
@@ -187,15 +187,15 @@
     {
       TT_Face       ttface = (TT_Face)size->face;
       SFNT_Service  sfnt   = (SFNT_Service) ttface->sfnt;
-      FT_ULong      index;
+      FT_ULong      strike_index;
 
 
-      error = sfnt->set_sbit_strike( ttface, req, &index );
+      error = sfnt->set_sbit_strike( ttface, req, &strike_index );
 
       if ( error )
         ttsize->strike_index = 0xFFFFFFFFUL;
       else
-        return tt_size_select( size, index );
+        return tt_size_select( size, strike_index );
     }
 
 #endif /* TT_CONFIG_OPTION_EMBEDDED_BITMAPS */
--- src/cff/cffobjs.h.ori       2006-02-15 07:44:31.000000000 
+++ src/cff/cffobjs.h   2007-01-14 17:04:50.000000000 
@@ -120,7 +120,7 @@
 
   FT_LOCAL( FT_Error )
   cff_size_select( FT_Size   size,
-                   FT_ULong  index );
+                   FT_ULong  strike_index );
 
 #endif
 
--- src/cff/cffobjs.c.ori       2006-04-29 07:31:16.000000000 
+++ src/cff/cffobjs.c   2007-01-14 17:03:25.000000000 
@@ -207,13 +207,13 @@
     {
       CFF_Face      cffface = (CFF_Face)size->face;
       SFNT_Service  sfnt    = (SFNT_Service)cffface->sfnt;
-      FT_ULong      index;
+      FT_ULong      strike_index;
 
 
-      if ( sfnt->set_sbit_strike( cffface, req, &index ) )
+      if ( sfnt->set_sbit_strike( cffface, req, &strike_index ) )
         cffsize->strike_index = 0xFFFFFFFFUL;
       else
-        return cff_size_select( size, index );
+        return cff_size_select( size, strike_index );
     }
 
 #endif /* TT_CONFIG_OPTION_EMBEDDED_BITMAPS */
--- src/base/ftobjs.c.ori       2007-01-12 09:28:44.000000000 
+++ src/base/ftobjs.c   2007-01-14 16:19:00.000000000 
@@ -2089,7 +2089,7 @@
   FT_Match_Size( FT_Face          face,
                  FT_Size_Request  req,
                  FT_Bool          ignore_width,
-                 FT_ULong*        index )
+                 FT_ULong*        size_index )
   {
     FT_Int   i;
     FT_Long  w, h;
@@ -2123,8 +2123,8 @@
 
       if ( w == FT_PIX_ROUND( bsize->x_ppem ) || ignore_width )
       {
-        if ( index )
-          *index = (FT_ULong)i;
+        if ( size_index )
+          *size_index = (FT_ULong)i;
 
         return FT_Err_Ok;
       }
--- src/type42/t42objs.h.ori    2006-01-13 14:53:28.000000000 
+++ src/type42/t42objs.h        2007-01-14 17:08:43.000000000 
@@ -86,7 +86,7 @@
 
   FT_LOCAL( FT_Error )
   T42_Size_Select( T42_Size  size,
-                   FT_ULong  index );
+                   FT_ULong  strike_index );
 
 
   FT_LOCAL( void )
--- src/gxvalid/gxvmorx5.c.ori  2005-09-28 07:34:45.000000000 
+++ src/gxvalid/gxvmorx5.c      2007-01-14 16:56:12.000000000 
@@ -109,16 +109,16 @@
 
 
   static void
-  gxv_morx_subtable_type5_InsertList_validate( FT_UShort      index,
+  gxv_morx_subtable_type5_InsertList_validate( FT_UShort      table_index,
                                                FT_UShort      count,
                                                FT_Bytes       table,
                                                FT_Bytes       limit,
                                                GXV_Validator  valid )
   {
-    FT_Bytes p = table + index * 2;
+    FT_Bytes p = table + table_index * 2;
 
 
-    while ( p < table + count * 2 + index * 2 )
+    while ( p < table + count * 2 + table_index * 2 )
     {
       FT_UShort  insert_glyphID;
 

The next two changes fix warnings about possibly uninitialized variables:

--- src/truetype/ttinterp.c.ori 2007-01-13 07:34:23.000000000 
+++ src/truetype/ttinterp.c     2007-01-14 17:36:59.000000000 
@@ -5249,6 +5249,7 @@
     {
       if ( CUR.pedantic_hinting )
         CUR.error = TT_Err_Invalid_Reference;
+      *refp = 0;
       return FAILURE;
     }
 
--- src/pcf/pcfread.c.ori       2006-07-08 21:31:24.000000000 
+++ src/pcf/pcfread.c   2007-01-14 17:33:14.000000000 
@@ -321,6 +321,7 @@
       }
 
   Fail:
+    *asize = 0;
     return error;
   }
 

And the last change avoids linking printf() and lots of C library code:

--- src/autofit/aftypes.h.ori   2006-11-28 08:09:20.000000000 
+++ src/autofit/aftypes.h       2007-01-14 17:49:15.000000000 
@@ -54,7 +54,7 @@
   /*************************************************************************/
 
 #define xxAF_USE_WARPER  /* only define to use warp hinting */
-#define AF_DEBUG
+/* #define AF_DEBUG */
 
 #ifdef AF_DEBUG
 
Ciao, Detlef
-- 
_ // address@hidden
\X/  Detlef Wuerkner, Langgoens/Germany