Re: [Gap-dev-discuss] Cynthiune : make ALSA output handle parameter changes between song

[Philippe Roussel]

Hi,

Le 21/05/2012 23:38, Riccardo Mottola a écrit :
> Hi Philippe,
> 
> Philippe Roussel wrote:
>> Hi,
>>
>> The appended patch allows me to play songs with different bitrates
>> correctly with the ALSA backend. I haven't tested endianness
>> modification but I'm confident it will work.
>>
>> Please test this as much as you can.
>>
> Your patch looks correct to me, but it doesn't work.
> I tried two scenarios
> 1) clean start. open WAV file. I get this error. The file is 22Khz stereo
> ALSA lib pcm.c:7482:(snd_pcm_set_params) Unable to get period size for
> PLAYBACK: Invalid argument
> 2012-05-21 23:25:48.298 Cynthiune[5549] Failed to set device
> parameters:Invalid
> argument

Can you reproduce this every time ? If yes could you try to find the
cause or at least send me a backtrace that leads to this error ?

> 2) clean start. open WAV file, 44Khz stereo, plays fine. Play MP3. Plays
> fine
> 3) the opposite of 2) works
> 
> 
> Thus your patch seems to solve the endianness problem and I will commit
> it. But it is not perfect yet...
> 
> I attach a test file. Play it as first file after cynthiune opens.

Unfortunately this file plays perfectly in every situation I tested...
On what architecture did you test this ?

Thanks,
Philippe