Re: [Gap-dev-discuss] Cynthiune on Mac

[Sebastian Reitenbach]

On Monday, July 23, 2012 16:09 CEST, Philippe Roussel <address@hidden> wrote: 
 
> On Mon, Jul 23, 2012 at 03:25:02PM +0200, Sebastian Reitenbach wrote:
> >  
> > On Monday, July 23, 2012 15:19 CEST, Philippe Roussel <address@hidden> 
> > wrote: 
> >  
> > > On Mon, Jul 23, 2012 at 01:21:07PM +0200, Sebastian Reitenbach wrote:
> > > > in the main GNUmakefile.preamble, it detect whether it can find 
> > > > musicbrainz3 or 5,
> > > > and if it finds it, it will pick it up, if not, then not.
> > > 
> > > I'm sorry but looking at the code I can't see how this is supposed to
> > > work...
> > > 
> > > > Otherwise giving make flags like:
> > > > 
> > > > make _have_musicbrainz5=no _have_musicbrainz3=no
> > > > 
> > > > should disable it unconditionally (haven't tried, but just looking at 
> > > > the makefile).
> > > 
> > > I can't find _have_musicbrainz anywhere in the tree. Are you sure this
> > > code is commited ?
> > 
> > Doh! You are right, its not yet committed. But I think could be.
> > It's the stuff Yavor sent to gap-dev-discuss@ June 7.th
> > 
> > I'll look at it and see that I get it committed.

It's in now. I additionally added a 
ifneq (yes,$(disable-musicbrainz))

around in the GNUmakefile.preamble,

so with musicbrainz installed, and you do not want to enable it, run:

make disable-musicbrainz=yes

Otherwise it will try to find it.

Further, I've seen, Riccardo was working on getting rid of the Bug report 
feature.
Cynthiune did not compile, so I also fixed that. Hope it will not interfere 
with Riccardo ;)

cheers,
Sebastian

> 
> Ok, thanks Sebastian.
> -- 
> My mom had Windows at work and it hurt her eyes real bad.
>