[Gnash-commit] [patch #8734] Patches for improving `--audio-dump` support in Gnash

[Nutchanon Wetchasit]

Follow-up Comment #1, patch #8734 (project gnash):

Patch 2 of 4: see the attahced
`0002_flush-wave-metadata-on-audio-dump-end.patch`.

This patch addresses the issue of an un-updated "data" and "RIFF" chunk length
<https://savannah.gnu.org/bugs/?45887#comment3>,
by making `WAVWriter`'s destructor seek back and re-write WAVE header when
the dumping ended (user closed the window, clicked File > Quit, or
Gnash reached the specified frame), before closing the output stream.

Might need a review since I don't know much about Gnash's convention
regarding log message.

This completes the fix of main issue in bug #45887.

*Caveat*: This patch provides no provision for signal handling; terminating
Gnash with Ctrl+C, Ctrl+, or using `kill` will still result in an incorrect
dump file (though still recoverable using FFmpeg/AVconv).

Gnash: 0.8.11dev (patched against git dc51f53 28-Aug-2015)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #34824)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_flush-wave-metadata-on-audio-dump-end.patch Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8734>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/