[Gnash-commit] [patch #8734] Patches for improving `--audio-dump` support in Gnash

[Bastiaan Jacques]

Follow-up Comment #2, patch #8734 (project gnash):


@@ -75,7 +76,19 @@ WAVWriter::WAVWriter(const std::string& wavefile)
 /* public */
 WAVWriter::~WAVWriter()
 {
-    if (file_stream) file_stream.close();
+    if (file_stream) {
+        // attempt to flush metadata


I think this comment should correspond to what is actually happening here,
i.e. something like:

// Seeking back to the beginning, in order to rewrite the
// header with information accumulated during writing.


+        file_stream.seekp(0);
+        if (file_stream.fail()) {
+            log_error("WAVWriter: Failed to flush audio dump metadata,
resulting file would be incomplete");
+        }
+        else {
+            write_wave_header(file_stream);
+        }
+
+        // close the stream
+        file_stream.close();
+    }
 }


Aside from that, both patches look good to me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8734>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/