[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash'
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation |
Date: |
Thu, 11 Feb 2016 14:32:19 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1 |
Follow-up Comment #1, patch #8909 (project gnash):
Patch 2 of 4:
See the attached
`0002_use-void-for-undefined-in-player-externalinterface-output.patch`.
Current code in Gnash (player)'s ExternalInterface data marshalling function
used "<undefined/>" string to represent `undefined` ActionScript value
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/ExternalInterface.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n117>,
whereas others used "<void/>" <https://savannah.gnu.org/bugs/?47004#comment7>.
This caused the `undefined` value returned
from ExternalInterface callback to be received by JavaScript as `null` instead
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/external.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n269>.
This patch fixes the disagreeing `undefined` value representation, and
adjusts the associated container-emulated tests to follow the new
representation.
Once this patch is applied, `js2flash-exception.html`
<https://savannah.gnu.org/bugs/?47004#comment4> test from bug #47004
should show a correct result.
Gnash: 0.8.11dev (patched against git 435d3e9 6-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
(file #36314)
_______________________________________________________
Additional Item Attachment:
File name:
0002_use-void-for-undefined-in-player-externalinterface-output.patch Size:2 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8909>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Nutchanon Wetchasit, 2016/02/11
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation,
Nutchanon Wetchasit <=
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Nutchanon Wetchasit, 2016/02/11
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Nutchanon Wetchasit, 2016/02/11
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Sandro Santilli, 2016/02/15
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Nutchanon Wetchasit, 2016/02/15
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Sandro Santilli, 2016/02/15
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Nutchanon Wetchasit, 2016/02/17
- [Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation, Sandro Santilli, 2016/02/17