[Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation

[Nutchanon Wetchasit]

Follow-up Comment #3, patch #8909 (project gnash):

Patch 4 of 4:
See the attached
`0004_remove-inband-player-externalinterface-return-value-check.patch`.

Current Gnash's implementation of `ExternalInterface.call()` treats string
return value "Error" and "SecurityError" as in-band indication of JavaScript
error
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/flash/external/ExternalInterface_as.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n298>.
This causes legitimate string return value of these messages to be passed
to ActionScript as `undefined`.

This patch removes the check, allowing string "Error" and "SecurityError"
to be returned to ActionScript properly; completing the fix of bug #47004. 

Once this patch is applied, `flash2js-errorstring.html` test
<https://savannah.gnu.org/bugs/?47004#comment2> from bug #47004
should show a correct result.

Gnash: 0.8.11dev (patched against git 435d3e9 6-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36316)
    _______________________________________________________

Additional Item Attachment:

File name:
0004_remove-inband-player-externalinterface-return-value-check.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8909>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/