[Gnash-commit] [patch #8909] Patches to fix exception handling in Gnash's ExternalInterface implementation

[Nutchanon Wetchasit]

Follow-up Comment #2, patch #8909 (project gnash):

Patch 3 of 4:
See the attached `0003_send-javascript-error-to-player-as-undefined.patch`.

Current NPAPI libgnashplugin's JavaScript invocation code sends string-based
_in-band_ failure notification to player when `NPN_Invoke()` returned failure
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/plugin.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n958>.
Doing so makes ordinary string return value "Error", "SecurityError" got
treated as error status on player side, and is discarded.

This patch removes the check, allowing the default `undefined` value
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/plugin.cpp?id=435d3e9aa7864883f6a2379fd318126113786475#n929>
to be passed back to the player in case of exception, which is a correct
behavior <https://savannah.gnu.org/bugs/?47004#comment3>;
partially fixing bug #47004.

Gnash: 0.8.11dev (patched against git 435d3e9 6-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36315)
    _______________________________________________________

Additional Item Attachment:

File name: 0003_send-javascript-error-to-player-as-undefined.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8909>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/