Re: [Gnash-dev] [patch] tolerate install-info missing and make distcheck fixes

[strk]

On Sat, Apr 29, 2006 at 12:41:43PM +0200, Patrice Dumas wrote:
> Here is the next version for the patch:
> 
> doc/C/Makefile.am
> 
> * use $< instead of gnash.info for for install such that gnash.info from
>   srcdir may be used

Good.

> * put the install-info stuff in a different rule than the installation
>   of the info file

I haven't seen this patch (different rule), missing ?

> * add a @ in front of the test, such that make don't stop if the test is
>   flase

It doesn't stop here. The @ char is only to suppress echo of input
code, am I missing something ?

> 
> * replace /sbin/install-info by install-info everywhere for consistency
>   (I don't mind if the reverse is used).

Sounds good to me, my install-info is in /usr/sbin.

> plugin/Makefile.am
> 
> * distribute player.h

Good. Applied.

--strk;