Re: [gnugo-devel] Re: Stack over-run

[Trevor Morris]

At 07:20 AM 2/16/2002 -0800, Daniel Bump wrote:
>
>Trevor wrote:
>
>> Basically, the assumption that (2 * MAX_BOARD * MAX_BOARD / 3)
>> is sufficicient for the string[] structure is wrong.
>
>Gunnar wrote:
>
>> > The new value ( MAX_BOARD * MAX_BOARD * 2 / 3 ) is still quite a bit
>> > deeper than GNU Go should ever try.
>> 
>> No, this is not safe. It's not only the reading code doing trymoves.
>> Unconditional_life() can get very close to filling the entire board
>> under certain circumstances. This was discussed in the list around
>> August 21 last year, in a thread with the subject "gnugo bug logs".
>
>I had forgotten Gunnar's comment when I checked trevor_1_25.2 into
>CVS. I suppose we should increase MAXSTACK again.

I changed MAXSTACK back (to MAX_BOARD * MAX_BOARD) locally, when
Gunnar send his message, so this is not the crux of the string[] problem.

My next patch is taking a while to put together, so that fix didn't
get into CVS yet.

-Trevor