[gnugo-devel] Re: Stack over-run

[Trevor Morris]

Here's a patch that causes an assertion at the cause of the
stack over-run.

http://www.public32.com/games/go/trevor_1_25.4

Here's another GTP command sequence that can cause the assert:
http://www.public32.com/games/go/bad_stack2.gz


Basically, the assumption that (2 * MAX_BOARD * MAX_BOARD / 3)
is sufficicient for the string[] structure is wrong.


Relatedly, in liberty.h, ASSERT1 can be turned off by setting
NDEBUG.  This is a Microsoft standard define for it's Release
builds, so instead of removing this define from the VC builds, 
could we rename this to something like "GG_NO_ASSERTS"

-Trevor