Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Efraim Flashner]

On Fri, 11 Dec 2015 15:22:31 +0100
Ricardo Wurmus <address@hidden> wrote:

>  [...]  
> 
>  [...]  
> 
> > diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> > index 43f957b..d0f65f0 100644
> > --- a/gnu/packages/openstack.scm
> > +++ b/gnu/packages/openstack.scm
> > @@ -750,3 +750,56 @@ LDAP.")
> >           ,@(alist-delete
> >              "python-oauthlib"
> >              (package-native-inputs keystoneclient)))))))
> > +
> > +(define-public python-swiftclient
> > +  (package
> > +    (name "python-swiftclient")
> > +    (version "2.6.0")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (pypi-uri "python-swiftclient" version))
> > +        (sha256
> > +          (base32
> > +           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))  
> 
> The alignment of “(base32” is too far to the right, I think.  (Are you
> using Emacs to automatically align expressions?)

I'm actually using vim. Haven't gotten the hang of emacs yet.

> 
> > +  (build-system python-build-system)
> > +  (native-inputs
> > +   `(("python-pbr", python-pbr)
> > +     ("python-setuptools" ,python-setuptools)
> > +     ;; some packages are needed for the tests
> > +     ("python-coverage" ,python-coverage)
> > +     ("python-discover" ,python-discover)
> > +     ("python-hacking" ,python-hacking)
> > +     ("python-mock" ,python-mock)
> > +     ("python-oslosphinx" ,python-oslosphinx)
> > +     ("python-keystoneclient" ,python-keystoneclient)
> > +     ("python-sphinx" ,python-sphinx)  
> 
> Sphix is probably for generating documentation, so I’d move this above
> the comment because it could be misunderstood.

ok

> 
> > +     ("python-testrepository" ,python-testrepository)
> > +     ("python-testtools" ,python-testtools)))
> > +  (propagated-inputs
> > +   `(("python-requests" ,python-requests)
> > +     ("python-six" ,python-six)))
> > +  (home-page "http://www.openstack.org/";)
> > +  (synopsis "OpenStack Object Storage API Client Library")
> > +  (description
> > +   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
> > +object storage using clusters of standardized servers to store petabytes of
> > +accessible data.  It is not a file system or real-time data storage 
> > system, but
> > +rather a long-term storage system for a more permanent type of static data 
> > that
> > +can be retrieved, leveraged, and then updated if necessary.  Primary 
> > examples of
> > +data that best fit this type of storage model are virtual machine images, 
> > photo
> > +storage, email storage and backup archiving. Having no central \"brain\" 
> > or  
>                                                ^___ two spaces, please :)
>                                                
> > +master point of control provides greater scalability, redundancy and 
> > permanence.")  
> 
> (Is it just me or are these lines really just a bit little longer than
> usual?)

I checked, this one ended at 82, so I fixed it.

> > +  (license asl2.0)))
> > +
> > +(define-public python2-swiftclient
> > +  (let ((swiftclient (package-with-python2 python-swiftclient)))
> > +    (package (inherit swiftclient)
> > +      (propagated-inputs
> > +       `(("python2-futures" ,python2-futures)
> > +         ,@(package-inputs swiftclient)))  
> 
> I think this should be “package-propagated-inputs” instead of
> “package-inputs”.

good catch!

> 
> > +      (native-inputs
> > +       `(("python2-keystoneclient" ,python2-keystoneclient)
> > +         ,@(alist-delete
> > +            "python-keystoneclient"
> > +            (package-native-inputs swiftclient)))))))
> > -- 
> > 2.6.2  
> 
> Otherwise okay.
> 
> ~~ Ricardo


-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

0003-gnu-Add-python-swiftclient.patch
Description: Text Data

pgpDgnbzs2PHy.pgp
Description: OpenPGP digital signature