Re: [PATCH] Add vcflib.

[Roel Janssen]

0001-gnu-Add-filevercmp-v2.patch
Description: Text Data

Ricardo Wurmus writes:

> Roel Janssen <address@hidden> writes:
>
>> Ricardo Wurmus writes:
>>
>>> Roel Janssen <address@hidden> writes:
>>>
>>>> From f0cb8c476e902e3351988f7c278b3682837c8cce Mon Sep 17 00:00:00 2001
>>>> From: Roel Janssen <address@hidden>
>>>> Date: Tue, 22 Mar 2016 15:47:06 +0100
>>>> Subject: [PATCH 5/8] gnu: Add filevercmp.
>>>
>>>> * gnu/packages/bioinformatics.scm (filevercmp): New variable.
>>>> ---
>>>>  gnu/packages/bioinformatics.scm | 28 ++++++++++++++++++++++++++++
>>>>  1 file changed, 28 insertions(+)
>>>
>>>> diff --git a/gnu/packages/bioinformatics.scm 
>>>> b/gnu/packages/bioinformatics.scm
>>>> index 0abccbc..261660f 100644
>>>> --- a/gnu/packages/bioinformatics.scm
>>>> +++ b/gnu/packages/bioinformatics.scm
>>>> @@ -4923,3 +4923,31 @@ combinatorial configurations.\" G Ehrlich - Journal 
>>>> of the ACM (JACM),
>>>>        (synopsis "Program for managing SOM (Self-Organizing Maps) neural 
>>>> networks")
>>>>        (description "Program for managing SOM (Self-Organizing Maps) 
>>>> neural networks.")
>>>>        (license license:gpl3))))
>>>> +
>>>> +(define-public filevercmp
>>>> +  (let ((commit "1a9b779b93d0b244040274794d402106907b71b7"))
>>>> +    (package
>>>> +      (name "filevercmp")
>>>> +      (version (string-append "0-1." (string-take commit 7)))
>>>> +      (source (origin
>>>> +        (method url-fetch)
>>>> +        (uri (string-append "https://github.com/ekg/filevercmp/archive/";
>>>> +                            commit ".tar.gz"))
>>>> +        (file-name "filevercmp-src.tar.gz")
>>>
>>> Is this on purpose?  Or should we use “(string-append name "-" version
>>> ".tar.gz")” instead?
>>
>> This is on purpose.  There is no released version.  Therefore I gave it
>> "version" 0, with a "-1" suffix for Guix, and the first seven characters
>> of commit hash.
>>
>> The download link includes the full commit hash.
>
> I see that my comment was ambiguous.  I meant the argument to
> “(file-name ...)”.  Instead of using “filevercmp-src.tar.gz” I think it
> would be better to include the generated version number by doing
> something like this:
>
>     (file-name (string-append name "-" version ".tar.gz"))

Oh, of course.  I attached an updated patch.

Kind regards,
Roel Janssen