Re: [Halevt-dev] Bashism in hvmount

[Marcos Talau]

Patrice Dumas <address@hidden> writes:

> I tested with dash, too and it worked fine with 9 for the flock and for
> the redirection.  With a redirection not matching the flock, it will still
> run but it won't lock anymore.
>

I guess that you ran the command `hvmount' instead of `hvumount'. Now, I
think that I understand the problem. Patch for fix it attached.

Regards,
Talau

--- a/scripts/hvmount.in        2010-08-02 20:34:36.000000000 -0300
+++ b/scripts/hvmount.in        2010-08-02 20:36:44.000000000 -0300
@@ -291,7 +291,7 @@
 elif [ $command = 'umount' ]; then
    if [ x"$udi" = x -a x"$mountpoint" = x -a x"$device" = x -a $umount_all = 
'no' ]; then
        mountarg=$1
-       shift
+       [ $# -gt 0 ] && shift
        if [ x"$mountarg" = x ]; then
            echo "umount requires an udi, a mountpoint, a device or -a" 1>&2
            exit 1

pgpTW_6cQZiu5.pgp
Description: PGP signature