Re: shisa: small memleaks

[Simon Josefsson]

Elrond <address@hidden> writes:

> On Thu, Mar 23, 2006 at 02:32:59PM +0100, Simon Josefsson wrote:
>> Elrond <address@hidden> writes:
>> 
>> > Hi Simon,
>> >
>> > Just wrote my first test apps with shisa (worked good, I
>> > got compataible arcfour-hmac hashes out of shisa).
>> 
>> Hi Elrond.  Excellent!
>
> Next try will be to see, if I get (unicode) passwords into
> shisa. ;)
> Don't hold your breath!

Shisa is simple, and usernames and passwords are 'char*' opaque, so it
should work.  Use UTF-8 though.

In general, Shishi should work with non-ASCII well.  It even do
SASLprep to canonicalize passwords, according to the latest Kerberos
specs.

>> > Running it with valgrind revealed two small memleaks:
>> >
>> > - shisa_done() should free dbh->dbs, if it is != NULL.
>
> You missed that it seems.
> (it wasn't in the patch.)

Oops!  Fixed now.

Thanks,
Simon