help-shishi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: shisa: small memleaks


From: Simon Josefsson
Subject: Re: shisa: small memleaks
Date: Thu, 23 Mar 2006 14:32:59 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

Elrond <address@hidden> writes:

> Hi Simon,
>
> Just wrote my first test apps with shisa (worked good, I
> got compataible arcfour-hmac hashes out of shisa).

Hi Elrond.  Excellent!

> Running it with valgrind revealed two small memleaks:
>
> - shisa_done() should free dbh->dbs, if it is != NULL.
> - shisa_cfg_db() should free "db" (suggested patch
>   appended)

Applied.

> - I don't know, if you like "const", I do.

I do too.

Btw, if you want to send more or larger patches, I think you'll need
to sign a FSF copyright assignment.  Are you willing to do this?  Let
me know offline and I'll send you the proper forms.

Thanks,
Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]