lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Nested contexts of any depth (junk InnerStaffGroup &InnerCho


From: Trevor Daniels
Subject: Re: [PATCH] Nested contexts of any depth (junk InnerStaffGroup &InnerChoirStaff)
Date: Wed, 8 Oct 2008 12:09:42 +0100

Valentin

This has quite a potential to muck things up in the docs, but if we want to make the change this is what will need to be done.

The global change which you have done does not work if both PianoStaff and GrandStaff appear in the same sentence or even paragraph. One example I spotted is on line 2367 of your patch - there will almost certainly be more, another is on 2451. I'm not sure how we flush these out though.

But if you can fix things like this let's do it.

Trevor

----- Original Message ----- From: "Valentin Villenave" <address@hidden>
To: "Neil Puttock" <address@hidden>
Cc: "lily-devel" <address@hidden>
Sent: Wednesday, October 08, 2008 11:34 AM
Subject: Re: [PATCH] Nested contexts of any depth (junk InnerStaffGroup &InnerChoirStaff)


2008/10/8 Valentin Villenave <address@hidden>:

(sending again because the attachments were too heavy)

Hi Neil,

before pushing it, could you have a look at the attached patch that
replaces PianoStaff with GrandStaff? I doubt it would change anything
to your work on nested contexts, but since I have made some
modifications in engraver-init.ly I prefer to give you a ping first.

The patch can be found at
http://villenave.info/valentin/lilypond/0001-Removed-PianoStaff-context-in-favor-of-GrandStaff.patch
and
http://villenave.info/valentin/lilypond/0002-Added-hara-kiri-grandstaff-regtest-to-replace-hara-k.patch

Cheers,
Valentin


_______________________________________________
lilypond-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/lilypond-devel






reply via email to

[Prev in Thread] Current Thread [Next in Thread]