lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Nested contexts of any depth (junk InnerStaffGroup &InnerCho


From: Trevor Daniels
Subject: Re: [PATCH] Nested contexts of any depth (junk InnerStaffGroup &InnerChoirStaff)
Date: Wed, 8 Oct 2008 16:23:40 +0100


Valentin, you wrote Wednesday, October 08, 2008 2:52 PM

2008/10/8 Trevor Daniels <address@hidden>:
This has quite a potential to muck things up in the docs, but if we want to
make the change this is what will need to be done.

Well, I have done everything I could to fix things (even in the
translated docs).

I saw that.  I think you've done a fantastic job!

The global change which you have done does not work if both PianoStaff and
GrandStaff appear in the same sentence or even paragraph.  One example I
spotted is on line 2367 of your patch - there will almost certainly be more,
another is on 2451.  I'm not sure how we flush these out though.

Yes, pitches.itely is the only file I have forgotten. I realized that too late.

I'm amazed.  I only browsed quickly through part of
the patch and hit by chance on the only two problems!

Even if there are some more it is not a serious issue.
We have a lot of doc reviewing to do, so they'll get
picked up soon.  Let's do it.

Here's a third patch to address this:
http://villenave.info/valentin/lilypond/0003-Syntax-consistency-in-pitches.itely.patch

Cheers,
Valentin

Trevor





reply via email to

[Prev in Thread] Current Thread [Next in Thread]