lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: showFirstLength


From: hanwenn
Subject: Re: showFirstLength
Date: Mon, 20 Oct 2008 17:37:54 -0700

Looks good to me.


http://codereview.appspot.com/7317/diff/7/8
File input/regression/skiptypesetting-show-last-or-first.ly (right):

http://codereview.appspot.com/7317/diff/7/8#newcode25
Line 25: showFirstLength = R1
can you double check that this will actually compare the way you think
it will in the regtest? (ie. changes in all three scores will hit the
regtest?)

You could also split this into three files.

http://codereview.appspot.com/7317/diff/7/10
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/7/10#newcode830
Line 830: (ly:moment-main-numerator moment)
this indent also looks off.

http://codereview.appspot.com/7317




reply via email to

[Prev in Thread] Current Thread [Next in Thread]