lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: showFirstLength


From: v . villenave
Subject: Re: showFirstLength
Date: Tue, 21 Oct 2008 01:10:05 -0700

OK. I have eventually left the skiptypesetting-show-last regtest, and
added two more regtests (skiptypesetting-show-first,
skiptypesetting-show-first-and-last).

Since I have your LGTM, I pushed the commit.


http://codereview.appspot.com/7317/diff/7/8
File input/regression/skiptypesetting-show-last-or-first.ly (right):

http://codereview.appspot.com/7317/diff/7/8#newcode25
Line 25: showFirstLength = R1
On 2008/10/21 00:37:54, hanwenn wrote:
can you double check that this will actually compare the way you think
it will
in the regtest? (ie. changes in all three scores will hit the
regtest?)

You could also split this into three files.

Done.

http://codereview.appspot.com/7317/diff/7/10
File scm/music-functions.scm (right):

http://codereview.appspot.com/7317/diff/7/10#newcode830
Line 830: (ly:moment-main-numerator moment)
On 2008/10/21 00:37:54, hanwenn wrote:
this indent also looks off.


Done.

http://codereview.appspot.com/7317




reply via email to

[Prev in Thread] Current Thread [Next in Thread]