lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix crash when a stencil routine is missing


From: Joe Neeman
Subject: Re: [PATCH v2] Fix crash when a stencil routine is missing
Date: Tue, 07 Jul 2009 10:38:12 -0700

On Tue, 2009-07-07 at 01:24 -0700, Patrick McCarty wrote:
> On Tue, Jul 07, 2009 at 08:16:45AM +0200, Werner LEMBERG wrote:
> > 
> > > The new option, -dwarning-as-error, does *not* turn every warning into
> > > an error.  It only turns specific warnings (that don't exist without
> > > this patch) into errors.
> > 
> > Then the name is indeed too generic and should be temporarily renamed
> > to something more specific until the code has been improved to convert
> > all warnings to errors.
> 
> I think it would be better to work on creating a generic
> -dwarning-as-error now instead.
> 
> I can see how to do it on the Scheme side (a simple rebinding).  Would
> I need to write preprocessor macros to achieve this for the C++ code?

On the C++ side, all warnings and programming_errors go through
Grob::programming_error, Grob::warning, Input::programming_error or
Input::warning. So you'd just need to modify those 4 functions.

Joe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]