[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Fix crash when a stencil routine is missing
From: |
Graham Percival |
Subject: |
Re: [PATCH v2] Fix crash when a stencil routine is missing |
Date: |
Mon, 6 Jul 2009 22:45:04 -0700 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jul 06, 2009 at 03:37:06PM -0700, Patrick McCarty wrote:
> On Mon, Jul 06, 2009 at 03:08:50PM -0700, Graham Percival wrote:
> > I don't see a huge urgency for this patch, so I would rather wait
> > until b) was non-existent. I totally agree that we should split
> > a) and c), though.
>
> I think there is a slight confusion about what my patch implements.
>
> The new option, -dwarning-as-error, does *not* turn every warning into
> an error. It only turns specific warnings (that don't exist without
> this patch) into errors.
Oh! Yes, I was definitely confused. (that said, I _do_ like the
notion of a "complete" -dwarning-as-error, for regtests, *if* we
can check them all)
OTOH, since you only want to warning-error-check certain files,
why not make -dwarning-as-error as I misunderstood, then enable it
in those specific svg-related regtests? We can work towards
adding it as a general makefile rule later.
I'm not certain if a -dsvg-warning-as-error patch is particularly
useful, even for the regtests.
Cheers,
- Graham
- [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Graham Percival, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Graham Percival, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Werner LEMBERG, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Graham Percival, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing,
Graham Percival <=
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Werner LEMBERG, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Joe Neeman, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, John Mandereau, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/06